[SSO] - [PR 1] - Rewrite password login to use PasswordLoginMethod #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
bwindels
reviewed
Aug 2, 2021
| } | ||
|
|
||
| async login(hsApi, deviceName) { | ||
| return this._platform.logger.run("passwordLogin", async log => |
There was a problem hiding this comment.
probably better to pass down the log item already in progress in startWithLogin, rather than to start a new log operation. The log argument is usually passed down as the last argument btw. Passing it down makes the /password request being logged as a child of the ongoing operation, I can show you what that looks like in the log viewer.
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
Obsoleted by #453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.