Fix asset build throwing and swallowing errors #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix `svg-colorizer` throwing errors on Windows - Fix `css-url-parser` swallowing errors - Fail SDK build script when some commands are failing
MadLittleMods
commented
Apr 19, 2022
| @@ -37,7 +37,7 @@ module.exports.buildColorizedSVG = function (svgLocation, primaryColor, secondar | |||
| if (svgCode === coloredSVGCode) { | |||
| throw new Error("svg-colorizer made no color replacements! The input svg should only contain colors #ff00ff (primary, case-sensitive) and #00ffff (secondary, case-sensitive)."); | |||
| } | |||
| const fileName = svgLocation.match(/.+\/(.+\.svg)/)[1]; | |||
| const fileName = svgLocation.match(/.+[/\\](.+\.svg)/)[1]; | |||
There was a problem hiding this comment.
Account for Windows file paths which use back slashes.
MadLittleMods
commented
Apr 19, 2022
| @@ -39,7 +39,7 @@ function colorsFromURL(url, colorMap) { | |||
| function processURL(decl, replacer, colorMap) { | |||
| const value = decl.value; | |||
| const parsed = valueParser(value); | |||
| parsed.walk(async node => { | |||
| parsed.walk(node => { | |||
There was a problem hiding this comment.
This was previously marked as async but await was never used here so it wasn't necessary. And had the side-effect of swallowing any error that occurred within the plugin so it looked like the asset build succeeded even though it didn't (UnhandledPromiseRejectionWarning: Unhandled promise rejection.).
MadLittleMods
commented
Apr 19, 2022
| @@ -1,4 +1,8 @@ | |||
| #!/bin/bash | |||
| # Exit whenever one of the commands fail with a non-zero exit code | |||
| set -e | |||
| set -o pipefail | |||
There was a problem hiding this comment.
As the comment describes: Exit whenever one of the commands fail with a non-zero exit code
This was referenced Apr 19, 2022
|
Thanks for the review @MidhunSureshR 🐇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix asset build throwing and swallowing errors
svg-colorizerthrowing errors with Windows file pathscss-url-parserswallowing errors because it wasasyncyarn build:sdk,build.sh) overall when some commands are failing