This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update libraries version
bmarty
suggested changes
Apr 19, 2018
compile 'com.android.support:cardview-v7:26.1.0' | ||
compile 'com.android.support:recyclerview-v7:26.1.0' | ||
compile 'com.android.support:appcompat-v7:27.1.1' | ||
compile 'com.android.support:design:27.1.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compileSdkVersion is set to 26, you should not use v27 of the lib
vector/build.gradle
Outdated
@@ -204,6 +208,7 @@ dependencies { | |||
appCompile 'com.google.firebase:firebase-messaging:11.8.0' | |||
|
|||
// fdroid flavor only | |||
compile project(path: ':matrix-sdk') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this line has been added?
manuroe
reviewed
Apr 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not forget to add Glide to open_source_licenses.html
update version to v7:27.1.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update libraries version
#2097