Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Use Glide library to display sticker #2163

Merged
merged 7 commits into from
Apr 19, 2018
Merged

Use Glide library to display sticker #2163

merged 7 commits into from
Apr 19, 2018

Conversation

Tyuoli
Copy link
Contributor

@Tyuoli Tyuoli commented Apr 19, 2018

Update libraries version

#2097

Update libraries version
@Tyuoli Tyuoli requested a review from bmarty April 19, 2018 08:08
compile 'com.android.support:cardview-v7:26.1.0'
compile 'com.android.support:recyclerview-v7:26.1.0'
compile 'com.android.support:appcompat-v7:27.1.1'
compile 'com.android.support:design:27.1.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compileSdkVersion is set to 26, you should not use v27 of the lib

@@ -204,6 +208,7 @@ dependencies {
appCompile 'com.google.firebase:firebase-messaging:11.8.0'

// fdroid flavor only
compile project(path: ':matrix-sdk')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this line has been added?

Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to add Glide to open_source_licenses.html

@bmarty bmarty merged commit 61d50bb into develop Apr 19, 2018
@bmarty bmarty deleted the display_sticker_glide branch April 19, 2018 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants