Add internal playback of audio files

[awesome-manuel]

This is a draft implementation of internal audio playback.

Pull Request Checklist

• Changes has been tested on an Android device or Android emulator with API 16
• UI change has been tested on both light and dark themes
• Pull request is based on the develop branch
• Pull request updates CHANGES.rst
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off

[intsven]

Here are some screenshots of how this looks:

[bmarty]

Hi @awesome-manuel ,
Thanks for the PR. After a quick review, the code LGTM. I will check at runtime.
FTR the core team is working more on RiotX now, but if all is Ok, I will merge the PR anyway.

[bmarty]

Pb I see so far:

• mp3 playback does not work. I haven't tested other format yet.
• When scrolling, the button state (play/pause) is not restored

[intsven]

When scrolling, the button state (play/pause) is not restored

What do you mean by that? When I scroll everything just keeps working like you would expect it

[intsven]

mp3 playback does not work. I haven't tested other format yet.

I usually use audio/mp4. Do we really need mp3 support because the Android MediaRecorder does not even support recording mp3?

[awesome-manuel]

Maybe fall back to download in case of MP3?

[intsven]

I have tested mp3 now and it works for me inline just as the other audio messages (m4a, ...).
I tested this file: https://ia802508.us.archive.org/5/items/testmp3testfile/mpthreetest.mp3

[awesome-manuel]

Can someone explain what this means exactly?

$ ./tools/check/check_code_quality.sh
Check drawable quantity
ERROR, missing drawable alternative.

[DoM1niC]

@awesome-manuel Could you add Support 4 .ogx files like WhatsApp ? It won't playback currently only over a Third Party Media Player possible, I think .ogx is Opus based Audiofile in my mind.

[awesome-manuel]

@bmarty any chance we can get this merged at all?

[ghost]

Sorry if this is not the correct place to ask, but does this mean this will be included in the next version?

[tuxayo]

Is there anything to take here for RiotX? At least the design principles?

[tuxayo]

RiotX issue: element-hq/element-android#29

[LarzlRael]

the play and pause icons appear even when the files are not audio, also it does not play all some formats like mp3 p m4a