This repository has been archived by the owner on May 6, 2020. It is now read-only.
Quick proposal for native widgets #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Nov 21, 2019
bmarty
reviewed
Nov 22, 2019
| } | ||
| ``` | ||
|
|
||
| Would result in the following room account data `content` for a client that is loading it using a Jitsi Native SDK (in this case consent is saved for the jitsi domain instead of per state event id): |
There was a problem hiding this comment.
Is it room account data or user account data?
| ```json | ||
| { | ||
| "widgets": { | ||
| ... |
There was a problem hiding this comment.
maybe add a real sample of data?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick proposal for native_widgets permissions.
Actually it's introducing more than just native/regular widgets, it's also introducing the notion of permission for a domain instead of state event id..
Maybe need to add a permission type field (eventId/domain)?