Ensure that uploaded keys are dicts #17097
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "message": "Not updating device_keys for user, user_id or device_id mismatch", | ||
| "user_id": user_id, | ||
| } | ||
| ) |
There was a problem hiding this comment.
Should these not be errors?
There was a problem hiding this comment.
This would result in us "rejecting" the OTKs and fallback keys, if they are present in the request.
| if ( | ||
| device_keys["user_id"] == user_id | ||
| and device_keys["device_id"] == device_id | ||
| ): |
There was a problem hiding this comment.
If we want to validate these things we should make pydantic models of the request format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the existing checks for
one_time_keysorfallback_keys, this adds a check thatdevice_keysis a JSON object.Also verifies that the uploaded keys match the uploading user.