New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows CAS SSO flow to provide user IDs composed of numbers only #17098
Conversation
Allows CAS SSO flow to provide user IDs composed of numbers only which will be prefixed
Allows CAS SSO flow to provide user IDs composed of numbers only which will be prefixed
Allows CAS SSO flow to provide user IDs composed of numbers only which will be prefixed
Allows CAS SSO flow to provide user IDs composed of numbers only which will be prefixed
Fix lint + miss c/p
Reformate proposed by lint test ...
unique def for test
Fix useless %
reformate proposed by lint test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't entirely meaning to review right now, but just an early look with a few comments, seems fine overall but I should look a bit more closely
I think for the other SSO providers we suggest using templates for this! |
Are you thinking about |
fix coma
Removed test, need real devops !
Remove test, need real devops !
lower case prefix for uid
Yes -- I wasn't suggesting it exists, but that there's benefit in doing things the same across the providers. You'll need to ask @reivilibre which way he prefers though! |
lower case prefix uid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're happy to land this as is
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)
Signed-off-by: Aurélien Grimpard aurelien@grimpard.net
Why : We use CAS and we have user IDs with only numbers so we need a way to let them connect to Synapse with CAS