Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include knock endpoints in worker federation docs #17163

Closed
wants to merge 2 commits into from
Closed

Include knock endpoints in worker federation docs #17163

wants to merge 2 commits into from

Conversation

AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented May 7, 2024 •
edited

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@AndrewFerr AndrewFerr requested a review from a team as a code owner May 7, 2024 12:10
@github-actions github-actions bot deployed to PR Documentation Preview May 7, 2024 12:12 Active
@clokep
Copy link
Contributor

clokep commented May 7, 2024

Like I mentioned at #17058 (comment) this probably needs to update sytest and complement too.

@anoadragon453
Copy link
Member

@AndrewFerr FYI I'm waiting for those changes in Sytest and Complement to appear before reviewing this PR.

@erikjohnston erikjohnston removed the request for review from a team May 14, 2024 12:03
@anoadragon453
Copy link
Member

@AndrewFerr and if you're not sure how to do this, you can follow my example: #17058 (comment)

@AndrewFerr
Copy link
Member Author

Turns out this was always the same as #17058 🤦‍♂️ Thanks for getting the Sytest & Complement changes in!

@AndrewFerr AndrewFerr closed this May 22, 2024
@AndrewFerr AndrewFerr deleted the af/docs-knock-worker-federation branch May 22, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndrewFerr @clokep @anoadragon453