Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with creating public rooms on workers #17177

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented May 13, 2024

If room publication is disabled then creating public rooms on workers would not work.

Introduced in #16811.

Stack trace:

AttributeError: 'GenericWorkerStore' object has no attribute 'set_room_is_public'
  File "synapse/http/server.py", line 332, in _async_render_wrapper
    callback_return = await self._async_render(request)
  File "synapse/http/server.py", line 544, in _async_render
    callback_return = await raw_callback_return
  File "synapse/rest/client/room.py", line 171, in on_POST
    return await self._do(request, requester)
  File "synapse/rest/client/room.py", line 176, in _do
    room_id, _, _ = await self._room_creation_handler.create_room(
  File "synapse/handlers/room.py", line 921, in create_room
    await self.store.set_room_is_public(room_id, False)

If room publication is disabled then creating public rooms on workers
would not work.

Introduced in #16811.
@erikjohnston erikjohnston marked this pull request as ready for review May 13, 2024 09:34
@erikjohnston erikjohnston requested a review from a team as a code owner May 13, 2024 09:34
@erikjohnston erikjohnston merged commit a2e6f43 into develop May 13, 2024
38 checks passed
@erikjohnston erikjohnston deleted the erikj/fix_set_room branch May 13, 2024 11:12
erikjohnston added a commit that referenced this pull request May 13, 2024
erikjohnston added a commit that referenced this pull request May 13, 2024
See #17177.

I'm an idiot and moved them to the wrong store 🤦
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants