-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add room_types
/not_room_types
filtering to Sliding Sync /sync
#17337
Add room_types
/not_room_types
filtering to Sliding Sync /sync
#17337
Conversation
synapse/storage/controllers/state.py
Outdated
# FIXME: Do we have to worry about gaps? What happens if we try to get a point | ||
# in the room we haven't backfilled before? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't affect this PR because we're just looking at the create event which we will always have but I'm curious about this for get_state_at(...)
in general.
For state in a room, do we have to worry about gaps? What happens if we try to get state a point in the room we haven't backfilled before?
I guess I just don't know if we have all historical state in the room. I know we have the whole auth chain of things which will be a subset of state 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikjohnston Is this a legit concern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked with @erikjohnston and got some knowledge.
In general, asking for state at a random position is dubious and we should careful about our usages.
It's not a problem in our current Sliding Sync usages because we're using it with the to_token
which is at the front of the room so there will always be some latest event before the to_token
to get state at that positon.
…-room-types Conflicts: tests/handlers/test_sliding_sync.py
…-room-types Conflicts: synapse/handlers/sliding_sync.py
Thanks for the review @erikjohnston 🦅 |
Add
room_types
/not_room_types
filtering to Sliding Sync/sync
Based on MSC3575: Sliding Sync
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)