Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init colorPicker component #23

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

faga295
Copy link
Collaborator

@faga295 faga295 commented Oct 14, 2022

#7

@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for element-plus-docs-histoire ready!

Name Link
🔨 Latest commit c9c020e
🔍 Latest deploy log https://app.netlify.com/sites/element-plus-docs-histoire/deploys/634a4ecaecc86d00096354d4
😎 Deploy Preview https://deploy-preview-23--element-plus-docs-histoire.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@FliPPeDround
Copy link
Collaborator

FliPPeDround commented Oct 15, 2022

Suggestion.

  • Each Variant should have Controls that correspond to it
  • Alpha Variant It doesn't look like you can adjust the size

eg: Alpha Variant Should be able to adjust alpha

@FliPPeDround
Copy link
Collaborator

And then, thank you so much for your enthusiastic contribution
@faga1

@faga295
Copy link
Collaborator Author

faga295 commented Oct 15, 2022

seems like we can't dynamicly change alpha attribute, and also in many other el component has the same problem

@faga295
Copy link
Collaborator Author

faga295 commented Oct 15, 2022

now it can adjust size,and added predefine checkbox, alpha controls would be late, because of its bug

@FliPPeDround FliPPeDround merged commit 070d80d into element-plus:master Oct 15, 2022
yang1206 pushed a commit to yang1206/element-plus-docs-histoire that referenced this pull request Dec 7, 2022
* feat: init colorPicker component

* chore: more controls

Co-authored-by: faga <lzc295592@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants