Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: init Skeleton component. #58

Merged
merged 5 commits into from Oct 18, 2022
Merged

feat: init Skeleton component. #58

merged 5 commits into from Oct 18, 2022

Conversation

akinocccc
Copy link
Contributor

@akinocccc akinocccc commented Oct 18, 2022 •
edited

#7

@netlify
Copy link

netlify bot commented Oct 18, 2022 •
edited

✅ Deploy Preview for element-plus-interactive-docs ready!

Name Link
🔨 Latest commit 73e6980
🔍 Latest deploy log https://app.netlify.com/sites/element-plus-interactive-docs/deploys/634e72cbd7f7170008690abf
😎 Deploy Preview https://deploy-preview-58--element-plus-interactive-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@akinocccc akinocccc mentioned this pull request Oct 18, 2022
Open
70 tasks
@FliPPeDround
Copy link
Collaborator

It would be nice to have a toggle control for the Animation

@akinocccc
Copy link
Contributor Author

It would be nice to have a toggle control for the Animation

ok, I'll add it immediately.

@akinocccc
Copy link
Contributor Author

It would be nice to have a toggle control for the Animation

I done it.

@FliPPeDround
Copy link
Collaborator

It would be nice to have a toggle control for the Animation

I done it.

great！but, usually we need to put the controls in Controls, not on the page.
image

@akinocccc
Copy link
Contributor Author

It would be nice to have a toggle control for the Animation
I have put the controls of the Animation in the Controls. Please check again what else I need to modify. Thanks!

@FliPPeDround
Copy link
Collaborator

It would be nice to have a toggle control for the Animation
I have put the controls of the Animation in the Controls. Please check again what else I need to modify. Thanks!

thx your PR

@FliPPeDround FliPPeDround merged commit 73d9f28 into element-plus:master Oct 18, 2022
yang1206 pushed a commit to yang1206/element-plus-docs-histoire that referenced this pull request Dec 7, 2022
@akinocccc @FliPPeDround
feat: init Skeleton component. (element-plus#58)
4be0d44 
* feat: init Skeleton component.

* feat: add toggle control for the Animation.

* feat: put the controls of Animation in Controls.

* feat: remove duplicate references

Co-authored-by: joypeng <70848683+FliPPeDround@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akinocccc @FliPPeDround