Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #70 and enforce use pnpm #71

Merged
merged 3 commits into from
Oct 6, 2023
Merged

fix: #70 and enforce use pnpm #71

merged 3 commits into from
Oct 6, 2023

Conversation

genffy
Copy link
Contributor

@genffy genffy commented Sep 25, 2023

No description provided.

@vercel
Copy link

vercel bot commented Sep 25, 2023

@genffy is attempting to deploy a commit to the Element Plus Team on Vercel.

A member of the Team first needs to authorize it.

@YunYouJun
Copy link
Member

When we enforce pnpm, we still need add legacy-peer-deps=true?

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
element-plus-nuxt-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 3:41pm

@genffy
Copy link
Contributor Author

genffy commented Oct 4, 2023

When we enforce pnpm, we still need add legacy-peer-deps=true?

Not necessary, but can skip preinstall to use npm T,T

@YunYouJun
Copy link
Member

It seems vercel build not work. Please update new pnpm-lock.yaml with pnpm@8.

@YunYouJun YunYouJun merged commit 9d549c5 into element-plus:main Oct 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants