fix(components): [select] support dynamic value for option

element-plus · Aug 5, 2022 · f0fb631 · f0fb631
1 parent ad1967a
commit f0fb631
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/components/select/src/option.vue b/packages/components/select/src/option.vue
@@ -65,10 +65,11 @@ export default defineComponent({
     const { visible, hover } = toRefs(states)
 
     const vm = getCurrentInstance().proxy
-    const key = (vm as unknown as SelectOptionProxy).value
+
     select.onOptionCreate(vm as unknown as SelectOptionProxy)
 
     onBeforeUnmount(() => {
+      const key = (vm as unknown as SelectOptionProxy).value
       const { selected } = select
       const selectedOptions = select.props.multiple ? selected : [selected]
       const doesSelected = selectedOptions.some((item) => {

diff --git a/packages/components/select/src/useOption.ts b/packages/components/select/src/useOption.ts
@@ -95,6 +95,10 @@ export function useOption(props, states) {
     () => props.value,
     (val, oldVal) => {
       const { remote, valueKey } = select.props
+      if (!Object.is(val, oldVal)) {
+        select.onOptionDestroy(oldVal, instance.proxy)
+        select.onOptionCreate(instance.proxy)
+      }
       if (!props.created && !remote) {
         if (
           valueKey &&