-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [cascader] reactive size change #12294
Conversation
👋 @MrWeilian, thank you for contributing element-plus. |
Hello @MrWeilian, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=12294 |
@MrWeilian Good job, would you mind adding a test for it? |
@MrWeilian You can submit it for a try. |
/cc @element-plus/backers |
* fix(components): [cascader] reactive size change * fix(components): [cascader] update style after calc * fix(components): [cascader] add test * fix(components): [cascader] mock offsetHeight * fix(components): [cascader] size type * fix(components): [cascader] spy on getter for height * fix(components): [cascader] mock css var * fix(components): [cascader] add comment
fixed: #12263 fixed
cascader
height is changed by reactive size changedPlease make sure these boxes are checked before submitting your PR, thank you!
dev
branch.