fix(components): [cascader] reactive size change #12294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @MrWeilian, thank you for contributing element-plus.
|
|
|
|
Hello @MrWeilian, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=12294 |
|
@MrWeilian Good job, would you mind adding a test for it? |
|
hi, xc boss, It seems that the |
|
@MrWeilian You can submit it for a try. |
MrWeilian
commented
Apr 3, 2023
chenxch
reviewed
Apr 4, 2023
MrWeilian
commented
Apr 5, 2023
chenxch
approved these changes
Apr 5, 2023
|
/cc @element-plus/backers |
tolking
approved these changes
Jul 23, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
* fix(components): [cascader] reactive size change * fix(components): [cascader] update style after calc * fix(components): [cascader] add test * fix(components): [cascader] mock offsetHeight * fix(components): [cascader] size type * fix(components): [cascader] spy on getter for height * fix(components): [cascader] mock css var * fix(components): [cascader] add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #12263 fixed
cascaderheight is changed by reactive size changedPlease make sure these boxes are checked before submitting your PR, thank you!
devbranch.