Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2M #13054

Merged
merged 16 commits into from
Jun 2, 2023
Merged

D2M #13054

merged 16 commits into from
Jun 2, 2023

Conversation

iamkun
Copy link
Contributor

@iamkun iamkun commented Jun 2, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 8fd857a

This pull request improves the documentation, code quality, and test reliability of several components, such as pagination, select, notification, and popper. It also adds a template for pull requests and updates a sponsor link.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 8fd857a

  • Add a template for pull requests with description, related issue, and explanation sections (link)
  • Update the URL of the sponsor logo for js.design with new plan and source parameters (link)
  • Add a buildStart hook to the MarkdownTransform plugin to find the component paths using glob and store them in a compPaths variable (link)
  • Remove the redundant code that was finding the component paths using glob in the MarkdownTransform plugin (link)
  • Remove an extra newline character in the markdown template for the contributors section (link)
  • Update the section titles from Attributes, Events, and Slots to API, and add subsection titles for Attributes, Events, and Slots in the pagination, result, and tag component documentation (link, link, link, link, link)
  • Simplify the type definition of the Tree interface using a generic index signature (link)
  • Remove unused imports and calls of the useRestoreActive hook from the message-box component (link, link)
  • Add a props object with zIndex prop to the mount function in the notification test (link)
  • Add an assertion to check the z-index style of the wrapper element in the notification test (link)
  • Remove the default value of 0 for the zIndex prop of the notification component (link)
  • Update the order of the style objects in the contentStyle computed property of the popper component, moving the props.popperStyle object to the end of the array (link, link)
  • Update the assertions in the content test for the popper component to reflect the new order of the style objects (link, link, link)
  • Extract the class arrays of the prev more and next more buttons in the pager component into computed properties called prevMoreKls and nextMoreKls (link, link, link)
  • Update the order of the props in the paginationProps object, moving the pageSize and defaultPageSize props to the top (link)
  • Add the currentPage and defaultCurrentPage props to the paginationProps object (link)
  • Add missing imports and calls of the sleep function to the select test (link, link, link)
  • Remove the byClick parameter from the selectOptionClick function in the option component and the handleOptionSelect function in the select context interface and the useSelect file (link, link, link, link)
  • Remove unused imports, assignments, and variables of the softFocus and isSilentBlur states from the select component and the useSelect file (link, link, link, link, link, link, link, link, link)
  • Add a local variable called ignoreFocusEvent to the useSelect file and use it to replace the softFocus and isSilentBlur variables and handle the focus and blur events on the select component (link, link, link, link)
  • Add a logic to check if the current focus event is inside the tooltip component and ignore the blur and focus events if so (link)

winchesHe and others added 14 commits May 20, 2023 10:28
* fix(components): [popper] prioritise users popper-style

fix: #12831

* test: fix packages/popper testcase
* fix(components): [select-v2] Fix border color error

* fix(components): [select] updated code
…12474)

* fix(components): [notification] fix props.zIndex lose efficacy bug

* fix(components): [notification] fix props.zIndex lose efficacy bug

* fix(components): [notification] fix props.zIndex lose efficacy bug

* fix(components): [notification] fix props.zIndex lose efficacy bug
* docs(components): [pagination] use new display tag

* docs(components): [pagination] update doc format

adjust attribute order

update default for attribute

update title

update description for attribute

* docs(components): [pagination] restores the order of attributes
* fix(components): [select] drop-down selection is not closed when blur

closed #10893, #10992

* fix(components): [select] optimize the triggering of blur event

* refactor(components): [select] optimize code
* fix(components): [steps] preserve the order of subcomponents

* fix: remove unused type

* add test cases
@element-bot
Copy link
Member

element-bot commented Jun 2, 2023

General Info

Current version: 2.3.5
Current time: 2023-06-02T04:51:33+00:00


2.3.6

2023-06-02

Bug fixes

Refactors

Other

@pull-request-triage
Copy link

👋 @iamkun, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Total changed files: 2

ℹ️ Files have been changed
Filename Status
use-restore-active Removed ⛔️
use-restore-active Removed ⛔️

Generated with ❤️ by Element Plus bot
Generated with

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Size Change: -458 B (0%)

Total Size: 1.34 MB

Filename Size Change
./dist/element-plus/dist/index.css 43.4 kB +19 B (0%)
./dist/element-plus/dist/index.full.js 377 kB -150 B (0%)
./dist/element-plus/dist/index.full.min.js 275 kB -85 B (0%)
./dist/element-plus/dist/index.full.min.mjs 271 kB -113 B (0%)
./dist/element-plus/dist/index.full.mjs 369 kB -129 B (0%)

compressed-size-action

chore: update changelog 2.3.6
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🧪 Playground Preview: https://element-plus.run/?pr=13054
Please comment the example via this playground if needed.

@iamkun iamkun merged commit 68a75a0 into master Jun 2, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet