Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(components): [pagination] use new display tag #12680

Merged
merged 3 commits into from
May 24, 2023
Merged

docs(components): [pagination] use new display tag #12680

merged 3 commits into from
May 24, 2023

Conversation

wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented May 4, 2023 •
edited
Loading

Related: #10754

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @wzc520pyfm, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented May 4, 2023

Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented May 4, 2023 •
edited
Loading

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 4, 2023
@wzc520pyfm
Copy link
Contributor Author

wzc520pyfm commented May 4, 2023 •
edited
Loading

Do I need to adjust the type of 'pager-count' and 'layout' in Attribute? How to adjust?

@github-actions
Copy link

github-actions bot commented May 4, 2023 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=12680
Please comment the example via this playground if needed.

@wzc520pyfm
docs(components): [pagination] update doc format
fb0e865 
adjust attribute order

update default for attribute

update title

update description for attribute
@wzc520pyfm wzc520pyfm requested a review from btea May 22, 2023 01:57
@tolking tolking merged commit c51c686 into element-plus:dev May 24, 2023
@wzc520pyfm wzc520pyfm mentioned this pull request Oct 29, 2023
Draft
3 tasks
consultation-applio pushed a commit to SimCote/element-plus that referenced this pull request Nov 10, 2023
@wzc520pyfm @dannyhebertbell
docs(components): [pagination] use new display tag (element-plus#12680)
40b0ea2 
* docs(components): [pagination] use new display tag

* docs(components): [pagination] update doc format

adjust attribute order

update default for attribute

update title

update description for attribute

* docs(components): [pagination] restores the order of attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@wzc520pyfm wzc520pyfm

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wzc520pyfm @tolking @btea