-
-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [date-picker] model-value unexpected changes when type is week #16795
base: dev
Are you sure you want to change the base?
Conversation
🧪 Playground Preview: https://element-plus.run/?pr=16795 |
@btea 大佬,这个可以review一下吗? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I don't understand why the deleted code was added. However, it does solve the problem. Maybe it needs to be reviewed by others.
当没有选择最终值的时候,也就是面板没有关闭,value还是改变了 |
if (selectionMode.value === 'week') { | ||
handleKeyControl(EVENT_CODE.down) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.fixed #16792