Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] What is the function of the outermost <div></div> tag. #1717

Closed
llk2yq opened this issue Mar 30, 2021 · 4 comments · Fixed by #1732
Closed

[Bug Report] What is the function of the outermost <div></div> tag. #1717

llk2yq opened this issue Mar 30, 2021 · 4 comments · Fixed by #1732
Assignees
@jw-foss
Labels
Project::Enhancement New feature or request

Comments

@llk2yq
Copy link

llk2yq commented Mar 30, 2021

Element Plus version

1.0.2-beta.36

OS/Browsers version

win10 / edge89

Vue version

3.0.9

Reproduction Link

https://github.com/element-plus/element-plus/blob/6cb474f46d3a10d42f88ed48e0f2d013682ba584/packages/card/src/index.vue

Steps to reproduce

Go to file and see line 2.

What is Expected?

No div tag

What is actually happening?

have div tag
@cokemine
Copy link
Contributor

Yeah. I think that 'div' is not really needed.

@jw-foss
Copy link
Member

jw-foss commented Mar 31, 2021

Yeah, exactly, you guys interested in making a PR?

@jw-foss
Copy link
Member

jw-foss commented Mar 31, 2021

If you do, please reply below I will assign it to you, otherwise I will fix this myself.

@jw-foss jw-foss self-assigned this Mar 31, 2021
@jw-foss jw-foss added the Project::Enhancement New feature or request label Mar 31, 2021
@cokemine
Copy link
Contributor

@JeremyWuuuuu
Let me make a PR and fix it. )

cokemine added a commit to cokemine/element-plus that referenced this issue Mar 31, 2021
@cokemine
style(card): remove needless div tag
7b148f7 
fix element-plus#1717
@cokemine cokemine mentioned this issue Mar 31, 2021
Merged
3 tasks
Ryan2128 pushed a commit that referenced this issue Apr 1, 2021
@cokemine
refactor(card): remove needless div tag (#1732)
fe3807b 
fix #1717
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jw-foss jw-foss

Labels
Project::Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(card): remove needless div tag cokemine/element-plus
3 participants
@jw-foss @llk2yq @cokemine