Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] [Dev branch]Please use import from 'vue' instead of '@vue/runtime-core' code in table package #2077

Closed
bitjjj opened this issue May 27, 2021 · 1 comment

Comments

@bitjjj
Copy link

bitjjj commented May 27, 2021

Element Plus version

1.0.2-beta.44

OS/Browsers version

MacOS

Vue version

3.1.0-beta.5

Reproduction Link

https://codepen.io/iamkun/pen/example

Steps to reproduce

in following two files:

packages/table/src/store/helper.ts

packages/table/src/table-column/defaults.ts

What is Expected?

in following two files:

packages/table/src/store/helper.ts

packages/table/src/table-column/defaults.ts

What is actually happening?

Rollup puts full @vue/runtime-core package code to build file.
It will lead to Vite can't hot reload page

msidolphin pushed a commit to msidolphin/element-plus that referenced this issue May 28, 2021
jw-foss pushed a commit that referenced this issue May 31, 2021
Co-authored-by: yangyu8 <yangyu8@kingsoft.com>
@iamkun
Copy link
Contributor

iamkun commented Jun 1, 2021

fixed in #2097

@iamkun iamkun closed this as completed Jun 1, 2021
hanx316 pushed a commit that referenced this issue Jun 3, 2021
* fix: hot reload (#2077) (#2097)

Co-authored-by: yangyu8 <yangyu8@kingsoft.com>

* fix: fix popper in dialog isn't enough space to position problem (#2102)

Co-authored-by: yangyu8 <yangyu8@kingsoft.com>

* feat: demo Composition API (#2099)

* feat: demo Composition API

* chore: update

* chore: update

* chore: update

* chore: update radio VCA doc (#2111)

* fix: ImageViewer isLast attribute calculation error issue (#1902) (#2125)

Co-authored-by: yangyu8 <yangyu8@kingsoft.com>

* fix(col): col should hidden when span is zero (#1769)

* fix: tabindex prop type (#2130)

Co-authored-by: Qian Jie <jie.qian@blockheaders.com>

* fix: week translations for hr locale (#2134)

Co-authored-by: wp178491 <wp178491@alibaba-inc.com>

* feat: use built-in throwError function. (#2131)

* feat: use built-in throwError function.

* Update index.vue

* Update index.vue

* feat(build): esbuild for single component build (#2112)

* feat(input): add input-style prop (#2117)

* feat(input): add input-style prop

* test(input): add test case

* fix: Cascader size issue when filterable and multiple are enabled (#2123)

Co-authored-by: yangyu8 <yangyu8@kingsoft.com>

* build(project): release/1-0-2-beta-46 (#2136)

- Update release change log and update release script

Co-authored-by: msidolphin <msidolphin@outlook.com>
Co-authored-by: yangyu8 <yangyu8@kingsoft.com>
Co-authored-by: 0song <82012629+0song@users.noreply.github.com>
Co-authored-by: 神楽坂みずき <45122329+cokemine@users.noreply.github.com>
Co-authored-by: bastarder <85257684@qq.com>
Co-authored-by: Qian Jie <jie.qian@blockheaders.com>
Co-authored-by: 好多大米 <lost1q84@gmail.com>
Co-authored-by: wp178491 <wp178491@alibaba-inc.com>
Co-authored-by: 波比小金刚 <2890636389@qq.com>
Co-authored-by: hangzou <zouhang@didiglobal.com>
Co-authored-by: Ryan2128 <33176053+Ryan2128@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants