Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): [color-picker] alpha-slider #10332

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

jw-foss
Copy link
Member

@jw-foss jw-foss commented Oct 31, 2022

  • Extract logic code out of color-picker/alpha-slider

Note

This MR may seem pretty big, so it is suggested to be reviewed by commits

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

* Extract logic code out of color-picker/alpha-slider
@github-actions
Copy link

github-actions bot commented Oct 31, 2022

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 31, 2022
@github-actions
Copy link

github-actions bot commented Oct 31, 2022

🧪 Playground Preview: https://element-plus.run/?pr=10332
Please comment the example via this playground if needed.

@jw-foss jw-foss changed the title [🚧 WIP] refactor(components): [color-picker] alpha-slider refactor(components): [color-picker] alpha-slider Nov 1, 2022
@tolking tolking merged commit 105d417 into dev Mar 1, 2023
@tolking tolking deleted the refactor/extract-logic-out-of-color-picker branch March 1, 2023 06:32
@element-bot element-bot mentioned this pull request Mar 3, 2023
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
* refactor(components): [color-picker] alpha-slider

* Extract logic code out of color-picker/alpha-slider

* fix: exposing methods

* chore: expose refs

---------

Co-authored-by: JeremyWuuuuu <15975785+JeremyWuuuuu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants