refactor(components): [date-picker] basic-date-table #10344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extract logic out of basic-date-table file.
|
|
|
Since I've moved the location of the code, it is suggested that we can utilize some online diff checker for the code I've moved to make it easier for review. Such as DiffChecker |
|
🧪 Playground Preview: https://element-plus.run/?pr=10344 |
ryuhangyeong
approved these changes
Nov 1, 2022
chenxch
reviewed
Nov 1, 2022
chenxch
reviewed
Nov 1, 2022
tolking
approved these changes
Aug 29, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic-date-tablefile.Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.