Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [card] adds footer slot #10357

Merged
merged 3 commits into from
Nov 6, 2023
Merged

feat(components): [card] adds footer slot #10357

merged 3 commits into from
Nov 6, 2023

Conversation

faga295
Copy link
Contributor

@faga295 faga295 commented Nov 2, 2022

adds footer slot

closed #6873

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @faga295, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Hello @faga295, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Nov 2, 2022 •
edited

@MARIOMARUI
Copy link
Contributor

可以的

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Nov 5, 2022
@github-actions
Copy link

github-actions bot commented Nov 5, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=10357
Please comment the example via this playground if needed.

@faga295
Copy link
Contributor Author

faga295 commented Feb 11, 2023

If this PR hasn't any problems, please merge it

@wzc520pyfm
Copy link
Contributor

wzc520pyfm commented Nov 5, 2023 •
edited

What is the current progress of this PR? I think we need a footer slot, too. Can you help check it out. @btea

btea
btea approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faga295 Sorry for responding so late. This feature looks great to me.

@btea
Copy link
Collaborator

btea commented Nov 6, 2023

@ryuhangyeong Do you think there are any other questions? If not, I think we can merge it.

@ryuhangyeong
Copy link
Member

@btea

I have no problem.

I think it's okay for me to merge too.

@btea btea merged commit dfad553 into element-plus:dev Nov 6, 2023
10 checks passed
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@faga295 @btea @dannyhebertbell
feat(components): [card] adds footer slot (element-plus#10357)
ff1a178 
feat(components): [card]

adds footer slot

closed element-plus#6873

Co-authored-by: btea <2356281422@qq.com>
@element-bot element-bot mentioned this pull request Nov 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@faga295 faga295

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Card element with footer slot
5 participants
@faga295 @MARIOMARUI @wzc520pyfm @btea @ryuhangyeong