Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): fix the problem that chrome 72 table doesnotdisplaydata #10640

Merged
merged 6 commits into from Aug 12, 2023
Merged

fix(components): fix the problem that chrome 72 table doesnotdisplaydata #10640

merged 6 commits into from Aug 12, 2023

Conversation

LiZheGuang
Copy link
Contributor

Fix the problem that the chrome 72 tab table does not display data. This is caused by the fact that the extension operator becomes an empty object in a special scenario

BREAKING CHANGE :
The writing method of shallow copy is replaced

closed #8770,#9071,#7038

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

微信截图_20221117234346
微信图片_20221117234439
微信截图_20221117234107
微信截图_20221117234316

@LiZheGuang
fix(components): fix the problem that chrome 72 table doesnotdisplaydata
a3bbb77 
Fix the problem that the chrome 72 tab table does not display data. This is caused by the fact that
the extension operator becomes an empty object in a special scenario

BREAKING CHANGE :
The writing method of shallow copy is replaced

closed element-plus#8770,element-plus#9071,element-plus#7038
@pull-request-triage
Copy link

👋 @LiZheGuang, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Nov 17, 2022
@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited

@github-actions
Copy link

Hello @LiZheGuang, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=10640
Please comment the example via this playground if needed.

@LiZheGuang
Copy link
Contributor Author

How long will it take to review this submission

@LiZheGuang
Copy link
Contributor Author

What's wrong with my PR submission? If you have verified it and think it doesn't work, please shut it down. If you haven't verified it and put it here again, I don't know how long to wait. One month, two months, eight years?

@tolking
Copy link
Member

tolking commented Dec 2, 2022

This question confuses me, and need help from other Reviewers.

@tolking tolking requested a review from a team December 2, 2022 11:14
@yoomin1106 yoomin1106 mentioned this pull request Feb 28, 2023
Closed
@btea
Copy link
Collaborator

btea commented Aug 11, 2023

I came across this issue recently, and I will review it.

@ryuhangyeong
Copy link
Member

@btea 👍

btea
btea approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LiZheGuang Thank you for your contribution ! 👍

@btea
Copy link
Collaborator

btea commented Aug 11, 2023

@tolking @ryuhangyeong Although I don't know the exact reason, it does solve the problem. 🤷‍♂️

ryuhangyeong
ryuhangyeong approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Since it is the same before and after the code change in that it creates a new object, there seems to be no problem with merging.

@btea btea merged commit 7e81efd into element-plus:dev Aug 12, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Aug 25, 2023
Merged
3 tasks
laizuan pushed a commit to laizuan/element-plus that referenced this pull request Sep 5, 2023
@LiZheGuang @btea @laizuan
fix(components): fix the problem that chrome 72 table doesnotdisplayd…
84fb96b 
…ata (element-plus#10640)

Fix the problem that the chrome 72 tab table does not display data. This is caused by the fact that
the extension operator becomes an empty object in a special scenario

BREAKING CHANGE :
The writing method of shallow copy is replaced

closed element-plus#8770,element-plus#9071,element-plus#7038

Co-authored-by: btea <2356281422@qq.com>
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@LiZheGuang @btea
fix(components): fix the problem that chrome 72 table doesnotdisplayd…
1d21a3c 
…ata (element-plus#10640)

Fix the problem that the chrome 72 tab table does not display data. This is caused by the fact that
the extension operator becomes an empty object in a special scenario

BREAKING CHANGE :
The writing method of shallow copy is replaced

closed element-plus#8770,element-plus#9071,element-plus#7038

Co-authored-by: btea <2356281422@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

@tolking tolking Awaiting requested review from tolking

Assignees

@LiZheGuang LiZheGuang

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
4 participants
@LiZheGuang @tolking @btea @ryuhangyeong