Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-chalk): [tab] correct padding of card item on hover #11283

Merged
merged 2 commits into from
Mar 1, 2023
Merged

fix(theme-chalk): [tab] correct padding of card item on hover #11283

merged 2 commits into from
Mar 1, 2023

Conversation

makedopamine
Copy link
Contributor

close #11256

@pull-request-triage
Copy link

👋 @makedopamine, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jan 14, 2023 •
edited

@github-actions
Copy link

Hello @makedopamine, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jan 14, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=11283
Please comment the example via this playground if needed.

@chenxch
Copy link
Member

chenxch commented Jan 31, 2023

Seems to consider removing :nth-child(2)

@makedopamine
Copy link
Contributor Author

Seems to consider removing :nth-child(2)

It's necessary for the nested Tabs component situation. Here is the related issue.

tolking
tolking approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenxch chenxch merged commit 18644cf into element-plus:dev Mar 1, 2023
@element-bot element-bot mentioned this pull request Mar 3, 2023
Merged
3 tasks
@makedopamine makedopamine deleted the fix/tab-style branch March 4, 2023 08:49
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
@makedopamine @loosheng
fix(theme-chalk): [tab] correct padding of card item on hover (elemen…
13bbf85 
…t-plus#11283)

* fix(theme-chalk): [tab] correct padding of card item on hover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

@tolking tolking tolking approved these changes

Assignees

@makedopamine makedopamine

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] [tabs] card类型的tabs第二项padding异常
3 participants
@makedopamine @chenxch @tolking