feat(components): [select] Add max-collapse-tags prop #11378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=11378 |
chenxch
approved these changes
Feb 1, 2023
jw-foss
reviewed
Feb 2, 2023
There was a problem hiding this comment.
@kooriookami left a few comments for your consideration.
Do you think we should also implement this for select-v2?
I'd also like you to give a tag to this API for marking its release version.
|
@element-plus/backers |
jw-foss
reviewed
Feb 14, 2023
jw-foss
reviewed
Feb 14, 2023
There was a problem hiding this comment.
@kooriookami one left over for you to complete, we are close!
3 tasks
|
@jw-foss What version tag of |
kooriookami
force-pushed
the
select/max-tag
branch
from
79db991
to
b80850c
Compare
|
All finished. |
jw-foss
approved these changes
Mar 10, 2023
# Conflicts: # docs/en-US/component/select.md
3 tasks
loosheng
pushed a commit
to loosheng/element-plus
that referenced
this pull request
Mar 26, 2023
…1378) * feat(components): [select] Add max-collapse-tags prop closed element-plus#7429 * feat(components): [select] * feat(components): update * feat: update * feat: update * feat: update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #7429
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.