feat(components): [tree-v2] add item-size attribute #11522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=11522 |
jw-foss
approved these changes
Feb 11, 2023
jw-foss
reviewed
Feb 11, 2023
btea
force-pushed
the
feat/tree-v2-itemSize
branch
from
1957de9
to
71152e5
Compare
|
@btea in addition to the comments above, do you think we can introduce a test case to cover this feature? |
Yes, I will add a test case and example. |
ryuhangyeong
approved these changes
Feb 12, 2023
|
@jw-foss Please review to see if there are other issues, if not I will merge it. |
loosheng
pushed a commit
to loosheng/element-plus
that referenced
this pull request
Mar 26, 2023
* feat(components): [tree-v2] add item-size attribute * fix: modify internal variable name * fix: extract itemSize prop * test: add test case * test: update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.close #11501