Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [image] Display error content when picture loading fails #11600

Merged
merged 6 commits into from
Apr 9, 2023
Merged

fix(components): [image] Display error content when picture loading fails #11600

merged 6 commits into from
Apr 9, 2023

Conversation

ljf1834
Copy link
Contributor

@ljf1834 ljf1834 commented Feb 15, 2023

fix #11585

@pull-request-triage
Copy link

👋 @ljf1834, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Feb 15, 2023
@github-actions
Copy link

Hello @ljf1834, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Feb 15, 2023 •
edited

@ljf1834 ljf1834 marked this pull request as draft February 15, 2023 08:40
@ljf1834 ljf1834 marked this pull request as ready for review February 15, 2023 08:53
@ljf1834 ljf1834 requested a review from tolking February 16, 2023 05:53
tolking
tolking reviewed Feb 16, 2023
View reviewed changes
packages/components/image/src/image.vue Outdated Show resolved Hide resolved
packages/components/image/src/image.vue Outdated Show resolved Hide resolved
packages/theme-chalk/src/image.scss Outdated Show resolved Hide resolved
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Feb 16, 2023
@ljf1834
Copy link
Contributor Author

ljf1834 commented Feb 16, 2023

@tolking 请审查

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=11600
Please comment the example via this playground if needed.

@tolking
Copy link
Member

tolking commented Feb 16, 2023

LGTM.

@ljf1834
Copy link
Contributor Author

ljf1834 commented Feb 16, 2023

@tolking Thank you very much for your guidance

@ljf1834 ljf1834 changed the title fix(components): [image] Add status attribute and set styles fix(components): [image] Display error content when picture loading fails Feb 17, 2023
@tolking tolking merged commit d172535 into element-plus:dev Apr 9, 2023
@element-bot element-bot mentioned this pull request Apr 23, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@ljf1834 @consultation-applio
fix(components): [image] Display error content when picture loading f…
e018ff5 
…ails (element-plus#11600)

* fix(components): [image] Add status attribute and set styles

* fix(components): [image] remove image wrapper container

* chore(components): [image] remove invalid test

* fix(components): [image] update

* chore(components): [image] Remove unwanted code and optimize code

* chore(components): [image] optimize code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

Assignees

@ljf1834 ljf1834

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] [image] if el-image has no width, then the error info will not display
2 participants
@ljf1834 @tolking