New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): fix/dialog-close-event #1164

Merged

zazzaz merged 2 commits into dev from fix/dialog-close-event

Dec 31, 2020

Member

jw-foss commented Dec 31, 2020 •

edited

Dialog now emits close event correctly, Drawer as well. close Dialog close event is not working #1157
Due to the specification of Transition, ElOverlay's render function has been updated.
Please make sure these boxes are checked before submitting your PR, thank you!

Make sure you follow Element's contributing guide English | (中文 | Español | Français).
Make sure you are merging your commits to dev branch.
Add some descriptions and refer to relative issues for your PR.


          fix(dialog): fix/dialog-close-event

e80a0ff

- Dialog now emits close event correctly

jw-foss requested a review from zazzaz

December 31, 2020 04:19


          fix overlay render error

823e556

zazzaz approved these changes

View reviewed changes

zazzaz merged commit cc8f825 into dev

zazzaz deleted the fix/dialog-close-event branch

December 31, 2020 06:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment