feat(components): add el-text component #11653

gimjin · 2023-02-19T09:04:01Z

Please make sure these boxes are checked before submitting your PR, thank you!

Make sure you follow contributing guide English | (中文 | Español | Français).
Make sure you are merging your commits to dev branch.
Add some descriptions and refer to relative issues for your PR.

Because vitepress import from published element-plus, so el-text doc example not working. The docs only be packaged after published element-plus has el-text.

Locally review, build first, and edit example vue files:

<template>
  <el-text class="mx-1" size="large">Large</el-text>
  <el-text class="mx-1">Default</el-text>
  <el-text class="mx-1" size="small">Small</el-text>
</template>

+ <script lang="ts" setup>
+ import { ElText } from '../../../dist/element-plus/es/index.mjs'
+ </script>

pull-request-triage · 2023-02-19T09:04:06Z

👋 @gimjin, seems like this is your first time contribution to element-plus.

Please make sure that you have read our guidelines and code of conduct before making a contribution.
You can comment with /label Components:[component_name] to add a label for which component you are working on.
You may join our for staying tuned.

github-actions · 2023-02-19T09:04:13Z

github-actions · 2023-02-19T09:04:16Z

Hello @gimjin, thank you for contributing to element-plus, please see our guideline to see how to make contribution

gimjin · 2023-02-19T09:12:24Z

Create el-text idea by How to use Element-Plus only, forget inefficiency DIV+CSS?

jw-foss · 2023-02-22T12:31:20Z

@gimjin thank you for the contribution, I will go through your PR and see if this matches our current design principle, we WILL ACCEPT this one eventually.

jw-foss · 2023-02-22T12:39:43Z

@gimjin I was wondering if you can reorganize your commits into smaller pieces with git reset --mixed, for instance:

Component implementation
Testing
Documentation

Dividing your changes into smaller ones will boost the review process.

github-actions · 2023-02-22T12:40:31Z

🧪 Playground Preview: https://element-plus.run/?pr=11653
Please comment the example via this playground if needed.

jw-foss · 2023-02-22T12:45:17Z

To make this work, you will need to introduce this component in packages/element-plus/component.ts file and include it in the default exports.

gimjin · 2023-02-23T12:50:40Z

@gimjin thank you for the contribution, I will go through your PR and see if this matches our current design principle, we WILL ACCEPT this one eventually.

thanks for your guidance @jw-foss , I've adjusted as required.

reorganize commits into smaller pieces
el-text in packages/element-plus/component.ts file and include it in the default exports

packages/components/text/src/text.ts

packages/theme-chalk/src/text.scss

docs/en-US/component/text.md

gimjin · 2023-02-25T06:00:18Z

Already modified code and pushed. @ryuhangyeong

gimjin · 2023-02-26T02:00:58Z

Do I want to synchronize with upstream/dev every push? I have just rebased the latest code.

git rebase -i upstream/dev
git push -f

jw-foss · 2023-02-26T02:07:09Z

Do I want to synchronize with upstream/dev every push? I have just rebased the latest code.
git rebase -i upstream/dev
git push -f

Technically you don't. Your commits will be squashed and merged onto the HEAD, meaning that you will only have 1 commit in the end, as long as there were no conflicts I don't think you should rebase for every push. BTW, in practical Git, we don't really use -i for rebasing the upstream, and for pushing, it is always recommended to use --force-with-lease instead of --force/-f, considering this is your own feature branch, -f is fine, just for making sure you don't accidentally push something to a shared branch, you should do that for every force push.

gimjin · 2023-02-27T02:29:31Z

#11724 PR is before this PR merged dev branch, github robot tip me behind and show MERGE BUTTON, after click the button robot auto create new merged dev commit. Because this is not my commit and pollute dev branch history, so run git force rebase.

I already know, only conflict when merging will rebase it.

@jw-foss thanks gift --force-with-lease unfamiliar option.

docs/.vitepress/crowdin/en-US/pages/component.json

packages/components/text/src/text.ts

packages/theme-chalk/src/text.scss

packages/components/text/__tests__/text.test.tsx

packages/components/text/src/text.vue

ryuhangyeong · 2023-03-04T01:42:50Z

@gimjin nice~

gimjin · 2023-03-06T01:26:25Z

@gimjin nice~

😸🥂

jw-foss · 2023-03-07T05:55:57Z

@gimjin thank you for your hard working!! I will review the ASAP 👍

jw-foss

@gimjin good job and excellent work! I have no further comments but one for the API naming, would you mind address it so we can merge this one and get it released!

docs/en-US/component/text.md

jw-foss

@gimjin good job and excellent work! I have no further comments but one for the API naming, would you mind address it so we can merge this one and get it released!

jw-foss · 2023-03-07T09:28:06Z

I will merge this later this week, due to the hotfix tonight.

packages/components/text/src/text.ts

jw-foss · 2023-03-10T07:32:25Z

@gimjin thank you for your excellent work and patient ❤️, I just merged this PR! Good job! 🚀

ryuhangyeong · 2023-03-10T08:52:59Z

@gimjin Thank you for your hard work~

gimjin · 2023-03-10T13:13:30Z

Thank you for review my graffiti code @jw-foss @ryuhangyeong @tolking @btea 🍻.

I have developed ellipsis tooltip and line-clamp in my line-clamp branch, but unit test some exceptions in el-tooltip, I will create PR after fix.

* test(components): [text] el-text unit test * docs(components): [text] el-text website documentation * feat(components): [text] el-text implementation * fix(components): [text] prop 'as' rename 'tag' * docs(components): [text] rename slot default, optimize document * test(components): [text] render text & class change the execution order * fix(components): [text] use template and render function together

pull-request-triage bot assigned gimjin Feb 19, 2023

pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Feb 19, 2023

github-actions bot added the Contribution::Community label Feb 19, 2023

github-actions bot added the CommitMessage::Qualified Qualified commit message label Feb 22, 2023

gimjin force-pushed the dev branch from 2180717 to 33b3732 Compare February 23, 2023 12:39

ryuhangyeong reviewed Feb 24, 2023

View reviewed changes

packages/components/text/src/text.ts Outdated Show resolved Hide resolved

ryuhangyeong reviewed Feb 25, 2023

View reviewed changes

packages/theme-chalk/src/text.scss Outdated Show resolved Hide resolved

ryuhangyeong reviewed Feb 25, 2023

View reviewed changes

docs/en-US/component/text.md Outdated Show resolved Hide resolved

gimjin force-pushed the dev branch from 33b3732 to 8958063 Compare February 25, 2023 05:56

gimjin force-pushed the dev branch from c173bfd to b14dd72 Compare February 26, 2023 01:49

gimjin requested a review from ryuhangyeong February 27, 2023 04:18

ryuhangyeong reviewed Feb 27, 2023

View reviewed changes

docs/.vitepress/crowdin/en-US/pages/component.json Show resolved Hide resolved

ryuhangyeong reviewed Feb 27, 2023

View reviewed changes

packages/components/text/src/text.ts Outdated Show resolved Hide resolved

ryuhangyeong reviewed Feb 27, 2023

View reviewed changes

packages/theme-chalk/src/text.scss Outdated Show resolved Hide resolved

gimjin force-pushed the dev branch 2 times, most recently from e109446 to 9d8c0c5 Compare February 27, 2023 15:16

tolking reviewed Mar 2, 2023

View reviewed changes

packages/components/text/__tests__/text.test.tsx Show resolved Hide resolved

packages/components/text/src/text.vue Outdated Show resolved Hide resolved

gimjin requested a review from tolking March 2, 2023 07:06

gimjin added 6 commits March 2, 2023 16:42

test(components): [text] el-text unit test

35835a0

docs(components): [text] el-text website documentation

39b8a97

feat(components): [text] el-text implementation

8263b26

fix(components): [text] prop 'as' rename 'tag'

d00d388

docs(components): [text] rename slot default, optimize document

7b19c59

test(components): [text] render text & class change the execution order

daae53c

gimjin force-pushed the dev branch from 555b711 to da8df92 Compare March 2, 2023 08:45

tolking reviewed Mar 2, 2023

View reviewed changes

packages/components/text/src/text.vue Outdated Show resolved Hide resolved

fix(components): [text] use template and render function together

fc9ceea

gimjin force-pushed the dev branch from da8df92 to fc9ceea Compare March 2, 2023 10:06

gimjin requested a review from tolking March 2, 2023 10:09

tolking approved these changes Mar 2, 2023

View reviewed changes

chenxch added release candidate Project::New Component labels Mar 2, 2023

jw-foss reviewed Mar 7, 2023

View reviewed changes

docs/en-US/component/text.md Show resolved Hide resolved

jw-foss approved these changes Mar 7, 2023

View reviewed changes

ryuhangyeong reviewed Mar 7, 2023

View reviewed changes

packages/components/text/src/text.ts Show resolved Hide resolved

jw-foss merged commit 4f78411 into element-plus:dev Mar 10, 2023

jw-foss added the Minor Version label Mar 10, 2023

element-bot mentioned this pull request Mar 12, 2023

D2M #11993

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(components): add el-text component #11653

feat(components): add el-text component #11653

gimjin commented Feb 19, 2023

pull-request-triage bot commented Feb 19, 2023

github-actions bot commented Feb 19, 2023 •

edited

github-actions bot commented Feb 19, 2023

gimjin commented Feb 19, 2023

jw-foss commented Feb 22, 2023 •

edited

jw-foss commented Feb 22, 2023

github-actions bot commented Feb 22, 2023 •

edited

jw-foss commented Feb 22, 2023

gimjin commented Feb 23, 2023

gimjin commented Feb 25, 2023 •

edited

gimjin commented Feb 26, 2023

jw-foss commented Feb 26, 2023

gimjin commented Feb 27, 2023

ryuhangyeong commented Mar 4, 2023

gimjin commented Mar 6, 2023

jw-foss commented Mar 7, 2023

jw-foss left a comment

jw-foss left a comment

jw-foss commented Mar 7, 2023

jw-foss commented Mar 10, 2023

ryuhangyeong commented Mar 10, 2023

gimjin commented Mar 10, 2023

feat(components): add el-text component #11653

feat(components): add el-text component #11653

Conversation

gimjin commented Feb 19, 2023

pull-request-triage bot commented Feb 19, 2023

github-actions bot commented Feb 19, 2023 • edited

github-actions bot commented Feb 19, 2023

gimjin commented Feb 19, 2023

jw-foss commented Feb 22, 2023 • edited

jw-foss commented Feb 22, 2023

github-actions bot commented Feb 22, 2023 • edited

jw-foss commented Feb 22, 2023

gimjin commented Feb 23, 2023

gimjin commented Feb 25, 2023 • edited

gimjin commented Feb 26, 2023

jw-foss commented Feb 26, 2023

gimjin commented Feb 27, 2023

ryuhangyeong commented Mar 4, 2023

gimjin commented Mar 6, 2023

jw-foss commented Mar 7, 2023

jw-foss left a comment

Choose a reason for hiding this comment

jw-foss left a comment

Choose a reason for hiding this comment

jw-foss commented Mar 7, 2023

jw-foss commented Mar 10, 2023

ryuhangyeong commented Mar 10, 2023

gimjin commented Mar 10, 2023

github-actions bot commented Feb 19, 2023 •

edited

jw-foss commented Feb 22, 2023 •

edited

github-actions bot commented Feb 22, 2023 •

edited

gimjin commented Feb 25, 2023 •

edited