Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [input-number] prevent input wheel events #11677

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix(components): [input-number] prevent input wheel events #11677

merged 1 commit into from
Feb 22, 2023

Conversation

Mario34
Copy link
Contributor

@Mario34 Mario34 commented Feb 21, 2023 •
edited by jw-foss

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @Mario34, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Feb 21, 2023
@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited

@github-actions
Copy link

Hello @Mario34, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@Mario34
Copy link
Contributor Author

Mario34 commented Feb 21, 2023

Details #11675

input-number组件与表格组件同时使用时，鼠标滚轮事件会改变input-number的值

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Feb 22, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=11677
Please comment the example via this playground if needed.

@jw-foss jw-foss merged commit d51b683 into element-plus:dev Feb 22, 2023
@element-bot element-bot mentioned this pull request Mar 3, 2023
Merged
3 tasks
@Mario34 Mario34 deleted the fix/input-number-wheel branch March 6, 2023 03:58
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
@Mario34 @loosheng
fix(components): [input-number] prevent input wheel events (element-p…
117f5e4 
…lus#11677)
@warmthsea warmthsea mentioned this pull request Dec 14, 2023
Closed
@makai1027
Copy link

image 代码内有这个事件，可是为什么没效果~~

@btea
Copy link
Collaborator

btea commented Feb 1, 2024

@makai1027 没效果是指鼠标滚轮还是会修改 input-number 的值？

@makai1027
Copy link

@makai1027 没效果是指鼠标滚轮还是会修改 input-number 的值？

会啊

不过我自己在组件上添加@wheel.prevent就好了，好奇怪
我用的2.3.4

@btea
Copy link
Collaborator

btea commented Feb 1, 2024

我测试是正常的。 link

@makai1027
Copy link

我测试是正常的。 link

我知道啥问题了
我装了 default-passive-events 这个依赖
移除就好了

感谢大哥

@kooriookami
Copy link
Member

这个看起来是table的问题，当初改动input-number是不是不太好

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jw-foss jw-foss jw-foss approved these changes

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@Mario34 Mario34

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
6 participants
@Mario34 @makai1027 @btea @kooriookami @jw-foss @ryuhangyeong