Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(components): [select-v2] input-icon margin-left (not first) #11830

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

wangcch
Copy link
Contributor

@wangcch wangcch commented Mar 6, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

close #11824

el-select-v2 doesn't use el-input wrapper. it does not inherit the style of el-input__icon.
https://github.com/element-plus/element-plus/blob/dev/packages/theme-chalk/src/input.scss#L294

@pull-request-triage
Copy link

👋 @wangcch, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Hello @wangcch, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@jw-foss
Copy link
Member

jw-foss commented Mar 10, 2023

LGTM! Thank you!

@jw-foss jw-foss merged commit 9870784 into element-plus:dev Mar 10, 2023
@wangcch wangcch deleted the style-select-v2-icon branch March 10, 2023 06:55
@element-bot element-bot mentioned this pull request Mar 12, 2023
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] [select-v2] el-select-v2的图标边距与el-select显示不一致
4 participants