feat(components): [button] add tag attribute #11853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=11853 |
chenxch
approved these changes
Mar 7, 2023
ryuhangyeong
reviewed
Mar 7, 2023
|
@tolking can we give this a badge which tells the users that this will only be available above |
jw-foss
approved these changes
Mar 8, 2023
ryuhangyeong
approved these changes
Mar 8, 2023
|
done. It is better to merge #11590 before this PR merger. Can you take a moment to look at it? |
|
@tolking The code seems to be conflicting. |
btea
approved these changes
Apr 10, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
May 4, 2023
* feat(components): [button] add tag attribute * fix: typo * docs: update * refactor(components): [button] detach button props * docs: update
|
@tolking thanks for doing that 😄 This was an annoying issue for us for testing using Capybara in our Rails app. We can now get rid of our git fork / custom implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8293
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.