Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [card] add body class #11869

Merged
merged 3 commits into from
Aug 10, 2023
Merged

feat(components): [card] add body class #11869

merged 3 commits into from
Aug 10, 2023

Conversation

uxuip
Copy link
Contributor

@uxuip uxuip commented Mar 7, 2023

新增body-class

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @uxuip, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Hello @uxuip, thank you for contributing to element-plus, please see our guideline to see how to make contribution

chenxch
chenxch reviewed Mar 7, 2023
View reviewed changes
packages/components/card/src/card.ts Outdated Show resolved Hide resolved
packages/components/card/src/card.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Mar 17, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=11869
Please comment the example via this playground if needed.

@btea btea merged commit 564476b into element-plus:dev Aug 10, 2023
@btea
Copy link
Collaborator

btea commented Aug 10, 2023

@uxuip Thank you for your contribution! ❤️

@yj-liuzepeng yj-liuzepeng mentioned this pull request Aug 24, 2023
Merged
3 tasks
@element-bot element-bot mentioned this pull request Aug 25, 2023
Merged
3 tasks
laizuan pushed a commit to laizuan/element-plus that referenced this pull request Sep 5, 2023
@uxuip @laizuan
feat(components): [card] add body class (element-plus#11869)
2f725eb 
* feat(components): [card]  add body class

* fix(components): [card] remove default value

* fix(components): [card] modify description
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@uxuip @dannyhebertbell
feat(components): [card] add body class (element-plus#11869)
dcbc41a 
* feat(components): [card]  add body class

* fix(components): [card] remove default value

* fix(components): [card] modify description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch left review comments

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@uxuip uxuip

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uxuip @btea @chenxch @ryuhangyeong