Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(theme-chalk): [rate] size #11920

Merged
merged 1 commit into from
Mar 10, 2023
Merged

style(theme-chalk): [rate] size #11920

merged 1 commit into from
Mar 10, 2023

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented Mar 8, 2023

close #11849

image

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Mar 8, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

🧪 Playground Preview: https://element-plus.run/?pr=11920
Please comment the example via this playground if needed.

mlvrkhn
mlvrkhn reviewed Mar 9, 2023
View reviewed changes
Copy link

@mlvrkhn mlvrkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks to me that there are only 2 available sizes, while 3 are expected as per Element Plus docs.

@jw-foss jw-foss merged commit 6077e64 into dev Mar 10, 2023
@jw-foss jw-foss deleted the style/rate-size branch March 10, 2023 07:30
@element-bot element-bot mentioned this pull request Mar 12, 2023
Merged
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
@chenxch @loosheng
style(theme-chalk): [rate] size (element-plus#11920)
c615136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlvrkhn mlvrkhn mlvrkhn left review comments

@jw-foss jw-foss jw-foss approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@chenxch chenxch

Labels
CommitMessage::Qualified Qualified commit message Component::Rate Minor Version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] [rate] Rating element size has no effect
4 participants
@chenxch @jw-foss @ryuhangyeong @mlvrkhn