Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [tooltip] remove mousemove listener when unmount #11940

Merged
merged 2 commits into from
Mar 12, 2023
Merged

fix(components): [tooltip] remove mousemove listener when unmount #11940

merged 2 commits into from
Mar 12, 2023

Conversation

zt123123
Copy link
Contributor

@zt123123 zt123123 commented Mar 9, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @zt123123, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Hello @zt123123, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@jw-foss
Copy link
Member

jw-foss commented Mar 10, 2023

Hi @zt123123 👋 , would you mind resolving the conflicts in order to get this merged? Thank you!

@jw-foss
Copy link
Member

jw-foss commented Mar 10, 2023

I resolved the conflicts myself 😄

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Mar 10, 2023
@zt123123
Copy link
Contributor Author

I resolved the conflicts myself 😄

thk

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=11940
Please comment the example via this playground if needed.

@btea btea merged commit 6a8a5aa into element-plus:dev Mar 12, 2023
@element-bot element-bot mentioned this pull request Mar 12, 2023
Merged
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
@zt123123 @jw-foss @loosheng
fix(components): [tooltip] remove mousemove listener when unmount (el…
3d7d2e3 
…ement-plus#11940)

Co-authored-by: Jeremy <15975785+jw-foss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jw-foss jw-foss jw-foss approved these changes

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@zt123123 zt123123

Labels
CommitMessage::Qualified Qualified commit message Component::Popover Component::Tooltip Contribution::Community Minor Version Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zt123123 @jw-foss @btea @ryuhangyeong