Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [select] correct update selectSize #11973

Merged
merged 3 commits into from
Apr 23, 2023

Conversation

acyza
Copy link
Contributor

@acyza acyza commented Mar 10, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fix #11962

@pull-request-triage
Copy link

👋 @acyza, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @acyza, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Mar 10, 2023

@github-actions
Copy link

github-actions bot commented Mar 10, 2023

🧪 Playground Preview: https://element-plus.run/?pr=11973
Please comment the example via this playground if needed.

@chenxch
Copy link
Member

chenxch commented Mar 10, 2023

@acyza Thanks for your contribution, would you mind adding a test case for this?

@acyza
Copy link
Contributor Author

acyza commented Mar 11, 2023

@acyza Thanks for your contribution, would you mind adding a test case for this?

https://github.com/element-plus/element-plus/blob/dev/packages/components/select/__tests__/select.test.ts#L2030
这条测试能过是因为它测试环境拿到的input的clientHeight始终为0,给它模拟一个clientHeight的值问题就显现出来了。

相关代码:https://github.com/element-plus/element-plus/blob/dev/packages/components/select/src/useSelect.ts#L377-L386

Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@chenxch
Copy link
Member

chenxch commented Apr 1, 2023

/cc @element-plus/backers

@acyza acyza reopened this Apr 12, 2023
@chenxch chenxch merged commit 4c93b47 into element-plus:dev Apr 23, 2023
9 checks passed
@element-bot element-bot mentioned this pull request Apr 23, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
* chore: 尝试恢复pr

* chore: update

* chore: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [select] selsect
3 participants