fix(components): [select] backspace delete disabled option #11995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @MrWeilian, thank you for contributing element-plus.
|
|
|
|
Hello @MrWeilian, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=11995 |
MrWeilian
commented
Mar 13, 2023
ryuhangyeong
approved these changes
Mar 16, 2023
|
LGTM 😃 |
|
@MrWeilian Could you resolve the code conflict? |
MrWeilian
force-pushed
the
fix/select-option-disabled
branch
from
df46e9c
to
09b3c78
Compare
done. but I found that the test is error with the |
|
@MrWeilian Don't worry, the test case is sometimes unstable, it will be fine after re-running. |
btea
approved these changes
Aug 13, 2023
tolking
approved these changes
Aug 13, 2023
laizuan
pushed a commit
to laizuan/element-plus
that referenced
this pull request
Sep 5, 2023
…lus#11995) * fix(components): [select] backspace delete disabled option * fix(components): [select] findLastIndex * fix(components): [select] simple polyfill findLastIndex in test file * fix(components): [select] add test for backspace * chore: lint
|
七月份提的pr，没给我合，合了一个八月份的，妙啊 |
|
建议提 pr 的时候可以关联一下issue，并看看有没相关的解决。。。 #11995 是三月份提的。。。 |
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…lus#11995) * fix(components): [select] backspace delete disabled option * fix(components): [select] findLastIndex * fix(components): [select] simple polyfill findLastIndex in test file * fix(components): [select] add test for backspace * chore: lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed: #11991
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.