Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upload data is not independent #12029

Merged
merged 2 commits into from
Mar 31, 2023
Merged

fix: Upload data is not independent #12029

merged 2 commits into from
Mar 31, 2023

Conversation

jianjunyuu
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

@pull-request-triage
Copy link

👋 @jianjunyuu, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @jianjunyuu, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=12029
Please comment the example via this playground if needed.

chenxch
chenxch reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他部分你根据这个调整一下，不用修改那么多

packages/components/upload/src/upload-content.vue Outdated Show resolved Hide resolved
packages/components/upload/src/upload-content.vue Outdated Show resolved Hide resolved
packages/components/upload/src/upload-content.vue Outdated Show resolved Hide resolved
packages/components/upload/src/upload-content.vue Outdated Show resolved Hide resolved
packages/components/upload/src/upload-content.vue Show resolved Hide resolved
packages/components/upload/src/upload-content.vue Outdated Show resolved Hide resolved
@mxismean
Copy link

新版本大概什么时候发布？

chenxch
chenxch approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.🚀

@chenxch
Copy link
Member

chenxch commented Mar 15, 2023

新版本大概什么时候发布？

正常情况一般周五下午

@mxismean
Copy link

新版本大概什么时候发布？

正常情况一般周五下午

好的 谢谢

@chenxch
Copy link
Member

chenxch commented Mar 20, 2023

/cc @element-plus/backers

@mxismean
Copy link

/cc @element-plus/backers

老哥，这个pr还没有合并么😂

@chenxch chenxch merged commit cc68d3e into element-plus:dev Mar 31, 2023
@element-bot element-bot mentioned this pull request Mar 31, 2023
Merged
3 tasks
@chenxch chenxch mentioned this pull request Apr 1, 2023
Merged
3 tasks
@btea btea mentioned this pull request Apr 6, 2023
Closed
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@jianjunyuu @consultation-applio
fix: Upload data is not independent (element-plus#12029)
1034317 
* fix: Upload data is not independent

* fix(components): [upload-content] copy data when beforeUpload
@HeftyKoo HeftyKoo mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

Assignees

@jianjunyuu jianjunyuu

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [upload] el-upload 上传多个文件 data 数据会被覆盖
3 participants
@jianjunyuu @mxismean @chenxch