Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks): [use-delayed-toggle] clear timer when call onClose #12056

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

wangcch
Copy link
Contributor

@wangcch wangcch commented Mar 15, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

#11833

  1. fix(hooks): [use-delayed-toggle] clear timer when call onClose
  2. test(hooks): [use-delayed-toggle] coverage 100%

@pull-request-triage
Copy link

👋 @wangcch, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Mar 15, 2023

@github-actions
Copy link

Hello @wangcch, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=12056
Please comment the example via this playground if needed.

@jw-foss jw-foss merged commit 8306138 into element-plus:dev Mar 16, 2023
@wangcch wangcch deleted the fix-use-delayed-toggle branch March 16, 2023 16:29
@element-bot element-bot mentioned this pull request Mar 19, 2023
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
…nt-plus#12056)

* fix(hooks): [use-delayed-toggle] clear timer when call onClose

* test(hooks): [use-delayed-toggle] coverage 100%
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
…nt-plus#12056)

* fix(hooks): [use-delayed-toggle] clear timer when call onClose

* test(hooks): [use-delayed-toggle] coverage 100%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants