Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): [tabs] example type error #12160

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix(docs): [tabs] example type error #12160

merged 2 commits into from
Mar 22, 2023

Conversation

bigsnowballhehe
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • [ √] Make sure you follow contributing guide English | (中文 | Español | Français).
  • [√ ] Make sure you are merging your commits to dev branch.
  • [√ ] Add some descriptions and refer to relative issues for your PR.

-example about tabs type error

@pull-request-triage
Copy link

👋 @bigsnowballhehe, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Mar 22, 2023
@github-actions
Copy link

github-actions bot commented Mar 22, 2023 •
edited

@github-actions
Copy link

Hello @bigsnowballhehe, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Mar 22, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=12160
Please comment the example via this playground if needed.

ryuhangyeong
ryuhangyeong approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ryuhangyeong ryuhangyeong merged commit 7773df6 into element-plus:dev Mar 22, 2023
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
@bigsnowballhehe @loosheng
fix(docs): [tabs] example type error (element-plus#12160)
021404f 
* fix(docs): [tabs] example type error

* fix(docs): [tabs] type replace

---------

Co-authored-by: alan.wu <snfzi@qq.com>
@bigsnowballhehe bigsnowballhehe deleted the docs/example-type-error branch March 27, 2023 10:47
@element-bot element-bot mentioned this pull request Mar 31, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@bigsnowballhehe @consultation-applio
fix(docs): [tabs] example type error (element-plus#12160)
cbf18c9 
* fix(docs): [tabs] example type error

* fix(docs): [tabs] type replace

---------

Co-authored-by: alan.wu <snfzi@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@bigsnowballhehe bigsnowballhehe

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bigsnowballhehe @ryuhangyeong