Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update pagination #12168

Closed
wants to merge 1 commit into from
Closed

docs: update pagination #12168

wants to merge 1 commit into from

Conversation

jumtp
Copy link
Contributor

@jumtp jumtp commented Mar 23, 2023

  • fix: missing sizes

* fix: missing sizes
@pull-request-triage
Copy link

👋 @jumtp, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Mar 23, 2023
@github-actions
Copy link

@github-actions
Copy link

Hello @jumtp, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@@ -74,7 +74,7 @@ pagination/more-elements
| pager-count | number of pagers. Pagination collapses when the total page count exceeds this value | ^[number]`5 \| 7 \| 9 \| 11 \| 13 \| 15 \| 17 \| 19 \| 21` | 7 |
| current-page / v-model:current-page | current page number | ^[number] | 1 |
| default-current-page | default initial value of current-page | ^[number] | - |
| layout | layout of Pagination, elements separated with a comma | ^[string]`string (consists of sizes, prev, pager, next, jumper, ->, total, slot)` | prev, pager, next, jumper, ->, total |
| layout | layout of Pagination, elements separated with a comma | ^[string]`string (consists of sizes, prev, pager, next, jumper, ->, total, slot)` | prev, sizes, pager, next, jumper, ->, total |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description

export const paginationProps = buildProps({
  layout: {
    type: String,
    default: (
      ['prev', 'pager', 'next', 'jumper', '->', 'total'] as LayoutKey[]
    ).join(', '),
  },
});

Thank your contribution.

but props default information matches the documentation information, so no changes are required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was my fault, didn't notice that was the default value, I thought it was an optional parameter

@jumtp jumtp closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants