fix(components): [carousel] two length transform optimize #12174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @MrWeilian, thank you for contributing element-plus.
|
|
|
|
Hello @MrWeilian, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=12174 |
|
Hi, I notice there is another situation that needs to be dealt with. Specifically, the addtional element appear in card mode. |
|
o~ thank you very much, it is resolved now |
|
@jw-foss hi, May I request review from you? And I don't know if this issue can be resolved in this way |
|
I think this problem shuold be solved, but they seem too busy. |
MrWeilian
force-pushed
the
fix/carousel-two-items
branch
from
c8fabbe
to
224574f
Compare
MrWeilian
force-pushed
the
fix/carousel-two-items
branch
from
3dbc425
to
55ba5b2
Compare
HeftyKoo
reviewed
Sep 13, 2023
MrWeilian
force-pushed
the
fix/carousel-two-items
branch
from
d98ecd8
to
87508c0
Compare
HeftyKoo
reviewed
Sep 25, 2023
btea
approved these changes
Oct 11, 2023
HeftyKoo
approved these changes
Oct 11, 2023
cc-hearts
pushed a commit
to cc-hearts/element-plus
that referenced
this pull request
Oct 15, 2023
…us#12174) * fix(components): [carousel] two length transform optimize * fix(components): [carousel] default init function slot * fix(components): [carousel] cancel optimize when loop is false * fix(components): [carousel] filter card type * fix: test * style: code lint * fix: cardtype * fix: remove test code * fix: act index * feat: use flattedchildren * fix: code lint * fix: rename and add comment
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…us#12174) * fix(components): [carousel] two length transform optimize * fix(components): [carousel] default init function slot * fix(components): [carousel] cancel optimize when loop is false * fix(components): [carousel] filter card type * fix: test * style: code lint * fix: cardtype * fix: remove test code * fix: act index * feat: use flattedchildren * fix: code lint * fix: rename and add comment
|
抱歉, 我将使用中文, 现在看来这个改动有很大的副作用 参见#15086 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #12139
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.