Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(components): fix generateExternal use wrong reference #12180

Merged
merged 1 commit into from
Apr 8, 2023
Merged

build(components): fix generateExternal use wrong reference #12180

merged 1 commit into from
Apr 8, 2023

Conversation

daolanfler
Copy link
Contributor

@daolanfler daolanfler commented Mar 24, 2023 •
edited

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

generateExternal is using a reference instead of shallow copy which might cause unnecessary memory usage which can slow the bundle process.

before: 
[09:02:56] Finished 'buildModules' after 1.22 min
[09:02:56] Finished 'shellTask:buildModules' after 1.27 min

after: 
[08:57:45] Finished 'buildModules' after 18 s
[08:57:45] Finished 'shellTask:buildModules' after 21 s

@pull-request-triage
Copy link

👋 @daolanfler, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Mar 24, 2023
@github-actions
Copy link

Hello @daolanfler, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Mar 24, 2023 •
edited

@daolanfler
Copy link
Contributor Author

image

the packages array becomes too big with repeated items

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Mar 25, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=12180
Please comment the example via this playground if needed.

btea
btea approved these changes Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolking tolking merged commit 682553a into element-plus:dev Apr 8, 2023
@tolking
Copy link
Member

tolking commented Apr 8, 2023

Thank for your contribution

@element-bot element-bot mentioned this pull request Apr 23, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@daolanfler @consultation-applio
build(components): fix generateExternal use wrong reference (element-…
2153062 
…plus#12180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@daolanfler daolanfler

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daolanfler @tolking @btea