Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [text] add to global components #12317

Merged
merged 1 commit into from
Apr 4, 2023
Merged

fix(components): [text] add to global components #12317

merged 1 commit into from
Apr 4, 2023

Conversation

Altermoe
Copy link
Contributor

@Altermoe Altermoe commented Apr 4, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @Altermoe, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Hello @Altermoe, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Apr 4, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

🧪 Playground Preview: https://element-plus.run/?pr=12317
Please comment the example via this playground if needed.

btea
btea approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution ❤️

@btea btea merged commit 52df601 into element-plus:dev Apr 4, 2023
11 checks passed
@element-bot element-bot mentioned this pull request Apr 7, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@Altermoe @consultation-applio
fix(components): [text] add to global components (element-plus#12317)
3a37124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@Altermoe Altermoe

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Altermoe @btea