feat(components): [progress] support set striped progress bar #12333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @wzc520pyfm, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=12333 |
btea
reviewed
Apr 6, 2023
wzc520pyfm
force-pushed
the
progress-striped
branch
from
de64890
to
64107a7
Compare
ryuhangyeong
approved these changes
Apr 8, 2023
|
Maybe can add a property to control whether to add animation, what do you think? @wzc520pyfm @ryuhangyeong |
I think it's cool, we can add a |
use `striped-flow` to get the stripes to flow
add `striped-flow` attribute update `duration` attribute description
wzc520pyfm
force-pushed
the
progress-striped
branch
from
64107a7
to
0a822fe
Compare
|
@btea A very cool idea! |
btea
reviewed
Apr 8, 2023
btea
reviewed
Apr 13, 2023
|
Thank you for your contribution ❤️ |
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
May 4, 2023
…t-plus#12333) * feat(components): [progress] support set striped progress bar * docs(components): [progress] add `striped` attribute * refactor(components): [progress] update striped prop and `bg-size` style * feat(components): [progress] add `striped-flow` attribute use `striped-flow` to get the stripes to flow * docs(components): [progress] add `striped-flow` attribute add `striped-flow` attribute update `duration` attribute description * docs(components): [progress] refactor `striped-progress` example * refactor(theme-chalk): [progress] refactor striped flow animation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the striped progress bar with the
stripedproperty.Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.