-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [dropdown] improve types #12514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 @ModyQyW, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
Their very first contribution
Needs Review
labels
Apr 19, 2023
tolking
reviewed
Apr 19, 2023
🧪 Playground Preview: https://element-plus.run/?pr=12514 |
tolking
approved these changes
Apr 19, 2023
btea
approved these changes
Apr 20, 2023
@ModyQyW Thank you for your contribution ❤️ |
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1st contribution
Their very first contribution
CommitMessage::Qualified
Qualified commit message
Contribution::Community
Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.This PR improves
dropdown
types.Previously, we have to write types to use dropdown ref to avoid
any
.After this, we can directly import and use the type.
Also, I updated the example file to use the new type.