Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [autocomplete] improve a11y #12647

Merged
merged 3 commits into from
Jul 22, 2023
Merged

fix(components): [autocomplete] improve a11y #12647

merged 3 commits into from
Jul 22, 2023

Conversation

init-qy
Copy link
Contributor

@init-qy init-qy commented Apr 28, 2023 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

close #12517

playground

@pull-request-triage
Copy link

👋 @init-qy, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Apr 28, 2023 •
edited

@github-actions
Copy link

Hello @init-qy, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Apr 28, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=12647
Please comment the example via this playground if needed.

@ryuhangyeong ryuhangyeong self-requested a review April 29, 2023 09:51
@btea btea merged commit 4e7f9b9 into element-plus:dev Jul 22, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Aug 4, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@init-qy @dannyhebertbell
fix(components): [autocomplete] improve a11y (element-plus#12647)
21383b0 
* fix(components): [autocomplete] improve a11y

* fix(components): add a11y tests

* fix: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong Awaiting requested review from ryuhangyeong

Assignees

@init-qy init-qy

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[autocomplete] Missing aria-expanded Required ARIA attribute is missing
3 participants
@init-qy @tolking @btea