Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(style): [tag] use new display tag #12659

Merged
merged 5 commits into from
May 3, 2023
Merged

docs(style): [tag] use new display tag #12659

merged 5 commits into from
May 3, 2023

Conversation

wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented Apr 28, 2023 •
edited

Related: #10754

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @wzc520pyfm, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Apr 28, 2023 •
edited

@github-actions
Copy link

Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Apr 28, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=12659
Please comment the example via this playground if needed.

btea
btea reviewed Apr 28, 2023
View reviewed changes
docs/en-US/component/tag.md Outdated Show resolved Hide resolved
@chenxch
Copy link
Member

chenxch commented Apr 28, 2023

Upgrade
#10754

If you are interested in participating in this document style upgrade plan, you can view these two documents and claim them.

@wzc520pyfm
Copy link
Contributor Author

@chenxch @btea
Thank you for your guidance, please checked again. And I'm ready to work on the other component document style.

tolking
tolking reviewed Apr 29, 2023
View reviewed changes
docs/en-US/component/tag.md Outdated Show resolved Hide resolved
docs/en-US/component/tag.md Outdated Show resolved Hide resolved
docs/en-US/component/tag.md Outdated Show resolved Hide resolved
@wzc520pyfm wzc520pyfm requested a review from tolking April 29, 2023 07:49
chenxch
chenxch reviewed Apr 29, 2023
View reviewed changes
packages/components/tag/src/tag.vue Outdated Show resolved Hide resolved
packages/components/tag/src/tag.vue Outdated Show resolved Hide resolved
chenxch
chenxch reviewed Apr 29, 2023
View reviewed changes
packages/components/check-tag/src/check-tag.vue Outdated Show resolved Hide resolved
docs/en-US/component/tag.md Outdated Show resolved Hide resolved
docs/en-US/component/tag.md Outdated Show resolved Hide resolved
docs/en-US/component/tag.md Outdated Show resolved Hide resolved
chenxch
chenxch approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.🫡

@tolking tolking merged commit 0d46d99 into element-plus:dev May 3, 2023
9 checks passed
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@wzc520pyfm @consultation-applio
docs(style): [tag] use new display tag (element-plus#12659)
baff0a3 
* docs(style): [tag] use new display tag

* refactor(components): [check] updated doc and code to new display tag

* docs(components): [tag] update format of doc

* style(components): [tag] undo redundant changes

* style(components): [tag] undo redundant changes and update tag doc
@wzc520pyfm wzc520pyfm mentioned this pull request Oct 29, 2023
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@wzc520pyfm wzc520pyfm

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wzc520pyfm @chenxch @tolking @btea